Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 1605037: Remove some remaining references to boilerplate functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4643 matching lines...) Expand 10 before | Expand all | Expand 10 after
4654 // place. 4654 // place.
4655 frame()->SyncRange(0, frame()->element_count() - 1); 4655 frame()->SyncRange(0, frame()->element_count() - 1);
4656 4656
4657 // Use the fast case closure allocation code that allocates in new 4657 // Use the fast case closure allocation code that allocates in new
4658 // space for nested functions that don't need literals cloning. 4658 // space for nested functions that don't need literals cloning.
4659 if (scope()->is_function_scope() && function_info->num_literals() == 0) { 4659 if (scope()->is_function_scope() && function_info->num_literals() == 0) {
4660 FastNewClosureStub stub; 4660 FastNewClosureStub stub;
4661 frame()->EmitPush(Immediate(function_info)); 4661 frame()->EmitPush(Immediate(function_info));
4662 return frame()->CallStub(&stub, 1); 4662 return frame()->CallStub(&stub, 1);
4663 } else { 4663 } else {
4664 // Call the runtime to instantiate the function boilerplate 4664 // Call the runtime to instantiate the function based on the
4665 // object. 4665 // shared function info.
4666 frame()->EmitPush(esi); 4666 frame()->EmitPush(esi);
4667 frame()->EmitPush(Immediate(function_info)); 4667 frame()->EmitPush(Immediate(function_info));
4668 return frame()->CallRuntime(Runtime::kNewClosure, 2); 4668 return frame()->CallRuntime(Runtime::kNewClosure, 2);
4669 } 4669 }
4670 } 4670 }
4671 4671
4672 4672
4673 void CodeGenerator::VisitFunctionLiteral(FunctionLiteral* node) { 4673 void CodeGenerator::VisitFunctionLiteral(FunctionLiteral* node) {
4674 Comment cmnt(masm_, "[ FunctionLiteral"); 4674 Comment cmnt(masm_, "[ FunctionLiteral");
4675 ASSERT(!in_safe_int32_mode()); 4675 ASSERT(!in_safe_int32_mode());
(...skipping 8212 matching lines...) Expand 10 before | Expand all | Expand 10 after
12888 12888
12889 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater) 12889 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater)
12890 // tagged as a small integer. 12890 // tagged as a small integer.
12891 __ bind(&runtime); 12891 __ bind(&runtime);
12892 __ TailCallRuntime(Runtime::kStringCompare, 2, 1); 12892 __ TailCallRuntime(Runtime::kStringCompare, 2, 1);
12893 } 12893 }
12894 12894
12895 #undef __ 12895 #undef __
12896 12896
12897 } } // namespace v8::internal 12897 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698