Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1605002: [Mac] Fix DCHECK() on page actions in preview. (Closed)

Created:
10 years, 8 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Fix DCHECK() on page actions in preview. Page actions can be image-less for a bit until their image loads. The image is visible and a default size is used. The DCHECK() just wanted to make sure that we weren't accidentally drawing an image of one size into a rect of a different size. BUG=37865 TEST=No DCHECK installing an extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43286

Patch Set 1 #

Patch Set 2 : BookmarkBar.xib? No idea. #

Patch Set 3 : Um, test should really match comment, no? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/cocoa/autocomplete_text_field_cell.mm View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
10 years, 8 months ago (2010-03-31 21:53:24 UTC) #1
John Grabowski
10 years, 8 months ago (2010-03-31 22:19:43 UTC) #2
!LGTM

Wait, I mean LGTM.

Powered by Google App Engine
This is Rietveld 408576698