Issue 160495: retry r2226, with a fix for a case where we could double free.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160495: retry r2226, with a fix for a case where we could double free. (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

retry r2226, with a fix for a case where we could double free. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22241

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -29 lines)			Patch
M	chrome/browser/gtk/bookmark_bubble_gtk.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bubble_gtk.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/download_shelf_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.cc	View	4 chunks	+79 lines, -26 lines	1 comment	Download
M	chrome/browser/gtk/infobar_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Stade

Could not repro before or after this change, with or without valgrind. Have a couple ...

11 years, 4 months ago (2009-08-01 01:34:00 UTC) #1

Evan Stade

wow valgrind is helpful. I should have read it first. The buildbot valgrind is saying ...

11 years, 4 months ago (2009-08-01 01:38:41 UTC) #2

OK, LG