Issue 160480: Convert parts of SavePage UI tests to more reliable browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160480: Convert parts of SavePage UI tests to more reliable browser tests. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Convert parts of SavePage UI tests to more reliable browser tests. Use a real notification for download completion - that's the main unflakying point. TEST=none http://crbug.com/3791 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22212

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -50 lines)			Patch
M	chrome/browser/download/save_package.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/download/save_page_browsertest.cc	View	1 chunk	+119 lines, -0 lines	1 comment	Download
M	chrome/browser/download/save_page_uitest.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

I plan to convert more parts in the future, but this is a start.

11 years, 4 months ago (2009-07-31 21:41:38 UTC) #1

Paul Godavari

11 years, 4 months ago (2009-07-31 22:11:26 UTC) #2

LGTM.

http://codereview.chromium.org/160480/diff/1/3
File chrome/browser/download/save_page_browsertest.cc (right):

http://codereview.chromium.org/160480/diff/1/3#newcode110
Line 110: // TODO(phajdan.jr): Also check the saved html file against golden
version.
Bug number.

http://codereview.chromium.org/160480/diff/1/6
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/160480/diff/1/6#newcode434
Line 434: // Downloads
---------------------------------------------------------------
"Saved Pages" instead?

Expand Messages | Collapse Messages