Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: net/base/host_resolver_impl.cc

Issue 160478: Modify a temporary hack to be more inclusive.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: change comment Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl.cc
===================================================================
--- net/base/host_resolver_impl.cc (revision 22029)
+++ net/base/host_resolver_impl.cc (working copy)
@@ -16,6 +16,7 @@
#endif
#include "base/compiler_specific.h"
+#include "base/debug_util.h"
#include "base/message_loop.h"
#include "base/stl_util-inl.h"
#include "base/string_util.h"
@@ -367,6 +368,14 @@
// See OnJobComplete(Job*) for why it is important not to clean out
// cancelled requests from Job::requests_.
void HostResolverImpl::CancelRequest(RequestHandle req_handle) {
+ if (shutdown_) {
+ // TODO(eroman): temp hack for: http://crbug.com/16972.
+ // Because we destroy outstanding requests during Shutdown() as part of
+ // hack http://crbug.com/15513, |req_handle| is already cancelled.
+ LOG(ERROR) << "Called HostResolverImpl::CancelRequest() after Shutdown().";
+ StackTrace().PrintBacktrace();
+ return;
+ }
Request* req = reinterpret_cast<Request*>(req_handle);
DCHECK(req);
DCHECK(req->job());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698