Status bubble limping in TOOLKIT_VIEWS....

Status bubble limping in TOOLKIT_VIEWS.

Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22229

[sky, 2009-07-31 21:22:02]

http://codereview.chromium.org/160474/diff/1/4
File views/widget/root_view.cc (right):

http://codereview.chromium.org/160474/diff/1/4#newcode14
Line 14: #include "views/fill_layout.h"
nit: before focus

http://codereview.chromium.org/160474/diff/1/4#newcode96
Line 96: DCHECK(contents_view && GetWidget()->GetNativeView()) <<
do we really care if the native widget has been created yet?

http://codereview.chromium.org/160474/diff/1/7
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/160474/diff/1/7#newcode827
Line 827: popup->MakeTransparent();
The only potentially worrisome thing here is what happens if the window manager
doesn't support transparency. I don't know how common that is.

[Ben Goodger (Google), 2009-07-31 22:20:11]

On Fri, Jul 31, 2009 at 2:22 PM, <sky@chromium.org> wrote:
> http://codereview.chromium.org/160474/diff/1/4#newcode96
> Line 96: DCHECK(contents_view && GetWidget()->GetNativeView()) <<
> do we really care if the native widget has been created yet?

Yes we do care... the reason is this code adds the NonClientView to
the hierarchy... which in turn causes all the other views to be added.
Code in ViewHierarchyChanged typically assumes GetWidget() returns
non-NULL.

> http://codereview.chromium.org/160474/diff/1/7
> File views/widget/widget_gtk.cc (right):
>
> http://codereview.chromium.org/160474/diff/1/7#newcode827
> Line 827: popup->MakeTransparent();
> The only potentially worrisome thing here is what happens if the window
> manager doesn't support transparency. I don't know how common that is.

I don't think we need to worry about that for ChromeOS which I believe
is TOOLKIT_VIEWS' only target. Otherwise we should make
MakeTransparent handle this case internally to itself so callers don't
care.

Snapshot updated.

-Ben

[sky, 2009-07-31 23:40:18]

LGTM