src/string-stream.cc - Issue 160452: Fix debug printing of pointers, and a keyed store with smi index error, in X6...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string-stream.cc

Issue 160452: Fix debug printing of pointers, and a keyed store with smi index error, in X6... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string-stream.cc

===================================================================

--- src/string-stream.cc (revision 2604)

+++ src/string-stream.cc (working copy)

@@ -153,7 +153,7 @@

}

break;

}

- case 'i': case 'd': case 'u': case 'x': case 'c': case 'p': case 'X': {

+ case 'i': case 'd': case 'u': case 'x': case 'c': case 'X': {

int value = current.data_.u_int_;

EmbeddedVector<char, 24> formatted;

int length = OS::SNPrintF(formatted, temp.start(), value);

@@ -167,6 +167,13 @@

Add(formatted.start());

break;

}

+ case 'p': {

+ void* value = current.data_.u_pointer_;

+ EmbeddedVector<char, 20> formatted;

+ OS::SNPrintF(formatted, temp.start(), value);

+ Add(formatted.start());

+ break;

+ }

default:

UNREACHABLE();

break;

« no previous file with comments | « src/string-stream.h ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »