Issue 160451: Guard local time posix functions from NaN value of invalid dates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160451: Guard local time posix functions from NaN value of invalid dates. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Guard local time posix functions from NaN value of invalid dates. Committed: http://code.google.com/p/v8/source/detail?r=2601

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
M	src/date-delay.js	View		4 chunks	+9 lines, -3 lines	0 comments	Download
M	src/platform.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-nullos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-posix.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/platform-win32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm http://codereview.chromium.org/160451/diff/1/3 File src/platform-posix.cc (right): http://codereview.chromium.org/160451/diff/1/3#newcode93 Line 93: if (NULL == t) return const_cast<char*>(""); Maybe ...

11 years, 4 months ago (2009-07-31 13:01:36 UTC) #2

William Hesse

11 years, 4 months ago (2009-07-31 13:15:44 UTC) #3

http://codereview.chromium.org/160451/diff/1/3
File src/platform-posix.cc (right):

http://codereview.chromium.org/160451/diff/1/3#newcode93
Line 93: if (NULL == t) return const_cast<char*>("");
On 2009/07/31 13:01:36, Christian Plesner Hansen wrote:
> Maybe OS::LocalTimezone should return a const char* instead, to avoid these
> const casts?

Done.

Expand Messages | Collapse Messages

Issue 160451: Guard local time posix functions from NaN value of invalid dates. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages