Issue 160449: Add virtual destructors to address a gcc warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160449: Add virtual destructors to address a gcc warning. (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/cfg.h	View		8 chunks	+17 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

The version of gcc on my workstation and the one on the buildbot must be ...

11 years, 4 months ago (2009-07-31 11:29:43 UTC) #1

Christian Plesner Hansen

11 years, 4 months ago (2009-07-31 12:17:16 UTC) #2

I would have suggested enabling the warning explicitly in the scons build script
at the same time.  But lgtm otherwise.