Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 160446: X64: enable stack sampling in profiler. (Closed)

Created:
11 years, 4 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

X64: enable stack sampling in profiler. Added necessary code to initialize Top::js_entry_sp value. Renamed 'test-log-ia32' test to 'test-log-stack-tracer' and enabled it in 64-bit version. Committed: http://code.google.com/p/v8/source/detail?r=2597

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -376 lines) Patch
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/codegen-x64.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +34 lines, -0 lines 2 comments Download
M test/cctest/SConscript View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-log-ia32.cc View 1 chunk +0 lines, -370 lines 0 comments Download
A test/cctest/test-log-stack-tracer.cc View 1 chunk +376 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 4 months ago (2009-07-31 08:20:48 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/160446/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/160446/diff/1/4#newcode6616 Line 6616: __ j(NegateCondition(zero), &not_outermost_js); What is the difference ...
11 years, 4 months ago (2009-07-31 10:00:12 UTC) #2
Mikhail Naganov
11 years, 4 months ago (2009-07-31 11:06:05 UTC) #3
http://codereview.chromium.org/160446/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/160446/diff/1/4#newcode6616
Line 6616: __ j(NegateCondition(zero), &not_outermost_js);
On 2009/07/31 10:00:12, William Hesse wrote:
> What is the difference between not_zero and NegateCondition(zero)?
> 

Thanks. I rarely touch code generation, so I'm not aware of all shortcuts it
has. Fixed.

Powered by Google App Engine
This is Rietveld 408576698