Issue 160444: add "remove" to download item context menu on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160444: add "remove" to download item context menu on mac (Closed)

Created:
11 years, 4 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari, Mohamed Mansour

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

add "remove" to download item context menu on mac BUG=60 TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22893

Patch Set 1 #

Patch Set 2 : fix menu validation #

Patch Set 3 : remove "hidden" flag from new menu entry #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -65 lines)			Patch
M	chrome/app/nibs/DownloadItem.xib	View	1 2	23 chunks	+94 lines, -65 lines	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.mm	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Note that the "leaves hole behind" problem also exists if this CL does not go ...

11 years, 4 months ago (2009-07-31 13:45:58 UTC) #2

LGTM.

Expand Messages | Collapse Messages