Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1604045: Fix crash on IP address change. (Closed)

Created:
10 years, 8 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
laforge
CC:
chromium-reviews
Visibility:
Public.

Description

Fix crash on IP address change. Revert r43908: "Flush socket pools and SPDY session pool properly on explicit requests and network changes." This change was reverted on the 375 branch, but not on trunk. BUG=41190 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44973

Patch Set 1 #

Patch Set 2 : Merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -185 lines) Patch
M net/base/host_resolver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/base/host_resolver_impl.h View 3 chunks +5 lines, -2 lines 0 comments Download
M net/base/host_resolver_impl.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M net/base/mapped_host_resolver.h View 1 chunk +0 lines, -1 line 0 comments Download
net/base/mock_host_resolver.h View 1 chunk +0 lines, -3 lines 0 comments Download
net/base/mock_host_resolver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_cache.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M net/http/http_network_layer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_network_layer.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 6 chunks +7 lines, -14 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +23 lines, -42 lines 0 comments Download
D net/http/http_network_session_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M net/net.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base.h View 6 chunks +14 lines, -4 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 4 chunks +13 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/socks_client_socket_pool_unittest.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M net/socket/tcp_client_socket_pool.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/tcp_client_socket_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_pool_unittest.cc View 4 chunks +30 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
willchan no longer on Chromium
10 years, 8 months ago (2010-04-19 22:28:38 UTC) #1
laforge
10 years, 8 months ago (2010-04-19 23:02:39 UTC) #2
LGTM

On Mon, Apr 19, 2010 at 3:28 PM, <willchan@chromium.org> wrote:

> Reviewers: laforge,
>
> Description:
> Fix crash on IP address change.
> Revert r43908: "Flush socket pools and SPDY session pool properly on
> explicit
> requests and network changes."
> This change was reverted on the 375 branch, but not on trunk.
> BUG=41190
>
> Please review this at http://codereview.chromium.org/1604045/show
>
> Affected files:
>  M net/base/host_resolver.h
>  M net/base/host_resolver_impl.h
>  M net/base/host_resolver_impl.cc
>  M net/base/host_resolver_impl_unittest.cc
>  M net/base/mapped_host_resolver.h
>  net/base/mock_host_resolver.h
>  net/base/mock_host_resolver.cc
>  M net/http/http_cache.cc
>  M net/http/http_network_layer.h
>  M net/http/http_network_layer.cc
>  M net/http/http_network_session.h
>  M net/http/http_network_session.cc
>  D net/http/http_network_session_unittest.cc
>  M net/http/http_network_transaction_unittest.cc
>  M net/net.gyp
>  M net/socket/client_socket_pool_base.h
>  M net/socket/client_socket_pool_base.cc
>  M net/socket/client_socket_pool_base_unittest.cc
>  M net/socket/socks_client_socket_pool.h
>  M net/socket/socks_client_socket_pool.cc
>  M net/socket/socks_client_socket_pool_unittest.cc
>  M net/socket/tcp_client_socket_pool.h
>  M net/socket/tcp_client_socket_pool.cc
>  M net/socket/tcp_client_socket_pool_unittest.cc
>  M net/spdy/spdy_network_transaction_unittest.cc
>  M net/spdy/spdy_session_unittest.cc
>  M net/spdy/spdy_stream_unittest.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698