Issue 1604041: Only search for the gpt tool if we need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1604041: Only search for the gpt tool if we need it. (Closed)

Created:
10 years, 8 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, dneiss, adlr

Visibility:
Public.

Description

Only search for the gpt tool if we need it.

Patch Set 2 : Move the call to locate_gpt up to fail earlier. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
	M	src/platform/installer/chromeos-common.sh	View	1	4 chunks	+20 lines, -12 lines	0 comments	Download
	M	src/scripts/emit_gpt_scripts.sh	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

LGTM, with one comment. http://codereview.chromium.org/1604041/diff/1/2 File src/platform/installer/chromeos-common.sh (right): http://codereview.chromium.org/1604041/diff/1/2#newcode283 src/platform/installer/chromeos-common.sh:283: locate_gpt You might want to ...

10 years, 8 months ago (2010-04-16 22:59:49 UTC) #2

robotboy

10 years, 8 months ago (2010-04-16 23:06:48 UTC) #3

http://codereview.chromium.org/1604041/diff/1/2
File src/platform/installer/chromeos-common.sh (right):

http://codereview.chromium.org/1604041/diff/1/2#newcode283
src/platform/installer/chromeos-common.sh:283: locate_gpt
Good point, I'll do that.

Expand Messages | Collapse Messages

Issue 1604041: Only search for the gpt tool if we need it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Move the call to locate_gpt up to fail earlier. #

Messages