Issue 1604030: Enable MMX for Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1604030: Enable MMX for Chrome (Closed)

Created:
10 years, 8 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, Evan Martin, Michael Moss, Sergey Ulanov, scherkus (not reviewing), agl

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable MMX for Chrome BUG=41259, 19113 TEST=build code that uses mmx intrinsics. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44325

Patch Set 4 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	build/common.gypi	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

http://codereview.chromium.org/1604030/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/1604030/diff/1/2#newcode895 build/common.gypi:895: '-mmmx', Can you just put this in the cflags ...

10 years, 8 months ago (2010-04-13 03:14:39 UTC) #2

fbarchard

Moved comment and added detail. http://codereview.chromium.org/1604030/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/1604030/diff/1/2#newcode895 build/common.gypi:895: '-mmmx', It needs to ...

10 years, 8 months ago (2010-04-13 03:46:10 UTC) #3

tony

10 years, 8 months ago (2010-04-13 04:00:34 UTC) #4

LGTM

http://codereview.chromium.org/1604030/diff/8001/9001
File build/common.gypi (right):

http://codereview.chromium.org/1604030/diff/8001/9001#newcode893
build/common.gypi:893: # -mmmx allows mmintrin.h to be used for mmx intrinsics.
Nit: maybe mention that --mmmx is needed for audio/video.

Expand Messages | Collapse Messages

Issue 1604030: Enable MMX for Chrome (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages