Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: net/http/http_request_headers_unittest.cc

Issue 1604011: Use HttpRequestHeaders for extra_headers. (Closed)
Patch Set: Address eroman comments. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_request_headers.cc ('k') | net/http/http_request_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_request_headers_unittest.cc
diff --git a/net/http/http_request_headers_unittest.cc b/net/http/http_request_headers_unittest.cc
index 29431d910d0608e0db65ff83e3da2c784b82ab8a..f3abfbe2ca728f4ab5ab4b788f7e54ad9ada1fdf 100644
--- a/net/http/http_request_headers_unittest.cc
+++ b/net/http/http_request_headers_unittest.cc
@@ -10,11 +10,17 @@ namespace net {
namespace {
-TEST(HttpRequestHeaders, SetRequestLine) {
+TEST(HttpRequestHeaders, HasHeader) {
HttpRequestHeaders headers;
- headers.SetRequestLine(
- HttpRequestHeaders::kGetMethod, "/foo", "1.1");
- EXPECT_EQ("GET /foo HTTP/1.1\r\n\r\n", headers.ToString());
+ headers.SetHeader("Foo", "bar");
+ EXPECT_TRUE(headers.HasHeader("foo"));
+ EXPECT_TRUE(headers.HasHeader("Foo"));
+ EXPECT_FALSE(headers.HasHeader("Fo"));
+
+ const HttpRequestHeaders& headers_ref = headers;
+ EXPECT_TRUE(headers_ref.HasHeader("foo"));
+ EXPECT_TRUE(headers_ref.HasHeader("Foo"));
+ EXPECT_FALSE(headers_ref.HasHeader("Fo"));
}
TEST(HttpRequestHeaders, SetHeader) {
@@ -50,6 +56,8 @@ TEST(HttpRequestHeaders, SetHeaderTwiceSamePrefix) {
headers.SetHeader("FooBar", "smokes");
headers.SetHeader("Foo", "crack");
EXPECT_EQ("FooBar: smokes\r\nFoo: crack\r\n\r\n", headers.ToString());
+ const HttpRequestHeaders& headers_ref = headers;
+ EXPECT_EQ("FooBar: smokes\r\nFoo: crack\r\n\r\n", headers_ref.ToString());
}
TEST(HttpRequestHeaders, SetEmptyHeader) {
@@ -135,6 +143,18 @@ TEST(HttpRequestHeaders, MergeFrom) {
EXPECT_EQ("A: A\r\nB: b\r\nC: c\r\n\r\n", headers.ToString());
}
+TEST(HttpRequestHeaders, CopyFrom) {
+ HttpRequestHeaders headers;
+ headers.SetHeader("A", "A");
+ headers.SetHeader("B", "B");
+
+ HttpRequestHeaders headers2;
+ headers2.SetHeader("B", "b");
+ headers2.SetHeader("C", "c");
+ headers.CopyFrom(headers2);
+ EXPECT_EQ("B: b\r\nC: c\r\n\r\n", headers.ToString());
+}
+
} // namespace
} // namespace net
« no previous file with comments | « net/http/http_request_headers.cc ('k') | net/http/http_request_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698