Simple register allocation for ARM. Only top of expression...

src/register-allocator.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 195 matching lines @@
   }
 
   // Copy the reference counts from this register file to the other.
   void CopyTo(RegisterFile* other) {
     for (int i = 0; i < kNumRegisters; i++) {
       other->ref_counts_[i] = ref_counts_[i];
     }
   }
 
  private:
-  static const int kNumRegisters = RegisterAllocatorConstants::kNumRegisters;
+  // C++ doesn't like zero length arrays, so we make the array length 1 even if
+  // we don't need it.
+  static const int kNumRegisters =

[Søren Thygesen Gjesse, 2010/04/07 10:46:51]

4 space indent.

[Erik Corry, 2010/04/07 12:49:17]

Done.

+    (RegisterAllocatorConstants::kNumRegisters == 0 ?

[Søren Thygesen Gjesse, 2010/04/07 10:46:51]

1 : RegisterAllocatorConstants::kNumRegisters on same line?

The expression does not need to be in ()'s - or move the last ) to just after ==
0.

[Erik Corry, 2010/04/07 12:49:17]

Done.

+        1 :
+        RegisterAllocatorConstants::kNumRegisters);
 
   int ref_counts_[kNumRegisters];
 
   // Very fast inlined loop to find a free register.  Used in
   // RegisterAllocator::AllocateWithoutSpilling.  Returns
   // kInvalidRegister if no free register found.
   int ScanForFreeRegister() {
     for (int i = 0; i < RegisterAllocatorConstants::kNumRegisters; i++) {
       if (!is_used(i)) return i;
     }
@@ skipping 80 matching lines @@
   }
 
  private:
   CodeGenerator* cgen_;
   RegisterFile registers_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_REGISTER_ALLOCATOR_H_