Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 160325: Speed up CalledAsConstructor.... (Closed)

Created:
11 years, 4 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Speed up CalledAsConstructor. Changed CalledAsConstructor to process the raw runtime stack directly, rather than using a StackFrameIterator. Using an interator turns out to be quite expensive and the vast majority of the work done is not relevant to deciding if we've been called as a constructor. This speeds up getElementById by ~13%. Committed: http://code.google.com/p/v8/source/detail?r=2578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/builtins.cc View 1 chunk +21 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 4 months ago (2009-07-29 12:16:58 UTC) #1
Kasper Lund
11 years, 4 months ago (2009-07-29 12:34:37 UTC) #2
STV. Another approach, which would be quite a bit harder to get right, would be
to use the custom construct code slot we have in functions, but I think we
should wait with that.

Powered by Google App Engine
This is Rietveld 408576698