Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 160316: Fix gyp condition to make 64bit just work (Closed)

Created:
11 years, 4 months ago by Joel Stanley (old)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix gyp condition for ia32 specific flags. We should test if it's ia32, not if it's not arm. Patch by Joel Stanley.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Joel Stanley (old)
This shouldn't affect anything else, and makes sense outside of the 64bit stuff.
11 years, 4 months ago (2009-07-29 05:33:30 UTC) #1
Dean McNamee
LG
11 years, 4 months ago (2009-07-29 15:33:00 UTC) #2
Evan Martin
11 years, 4 months ago (2009-07-29 17:08:19 UTC) #3
sorry abou tthat

Powered by Google App Engine
This is Rietveld 408576698