chrome/browser/extensions/external_registry_extension_provider_win.cc - Issue 160311: Pull CrxInstaller out of ExtensionsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_extension_provider_win.cc

Issue 160311: Pull CrxInstaller out of ExtensionsService. (Closed)

Patch Set: Fix leak of SandboxedExtensionUnpacker Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_pref_extension_provider.cc ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_registry_extension_provider_win.cc

diff --git a/chrome/browser/extensions/external_registry_extension_provider_win.cc b/chrome/browser/extensions/external_registry_extension_provider_win.cc

index 3809eb4f3543b5d5604725b65d0032885389b21f..d8057a03bf8dcb3beca979fa6bdff60dba5822a7 100644

--- a/chrome/browser/extensions/external_registry_extension_provider_win.cc

+++ b/chrome/browser/extensions/external_registry_extension_provider_win.cc

@@ -51,7 +51,8 @@ void ExternalRegistryExtensionProvider::VisitRegisteredExtension(

scoped_ptr<Version> version;

version.reset(Version::GetVersionFromString(extension_version));

FilePath path = FilePath::FromWStringHack(extension_path);

- visitor->OnExternalExtensionFound(id, version.get(), path);

+ visitor->OnExternalExtensionFound(id, version.get(), path,

+ Extension::EXTERNAL_REGISTRY);

} else {

// TODO(erikkay): find a way to get this into about:extensions

LOG(WARNING) << "Missing value " << kRegistryExtensionVersion <<