Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 160311: Pull CrxInstaller out of ExtensionsService. (Closed)
Patch Set: Fix leak of SandboxedExtensionUnpacker Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index bb14931c4627e130a6f3bcf19079c26f8cca8e08..5fa3bd2192a8781bb247f0f0796c9c16786acdca 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -209,14 +209,7 @@ void ExtensionUpdater::OnCRXFetchComplete(const GURL& url,
void ExtensionUpdater::OnCRXFileWritten(const std::string& id,
const FilePath& path) {
- // TODO(asargent) - Instead of calling InstallExtension here, we should have
- // an UpdateExtension method in ExtensionsService and rely on it to check
- // that the extension is still installed, and still an older version than
- // what we're handing it.
- // (http://crbug.com/12764).
- ExtensionInstallCallback* callback =
- NewCallback(this, &ExtensionUpdater::OnExtensionInstallFinished);
- service_->UpdateExtension(id, path, false, callback);
+ service_->UpdateExtension(id, path);
}
void ExtensionUpdater::OnExtensionInstallFinished(const FilePath& path,
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_updater_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698