src/objects-inl.h - Issue 1603002: Make check for writes without remembered set updates less restrictive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1603002: Make check for writes without remembered set updates less restrictive. (Closed)

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 6d7bad751210ef2855ea8031c5f197684077f074..d363d4d6ab29847abca988e340afc65862e9eff2 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -742,7 +742,8 @@ Object* Object::GetProperty(String* key, PropertyAttributes* attributes) {

} else { \

ASSERT(mode == SKIP_WRITE_BARRIER); \

ASSERT(Heap::InNewSpace(object) || \

- !Heap::InNewSpace(READ_FIELD(object, offset))); \

+ !Heap::InNewSpace(READ_FIELD(object, offset)) || \

+ Page::IsRSetSet(object->address(), offset)); \

}

#define READ_DOUBLE_FIELD(p, offset) \

« no previous file with comments | « no previous file | no next file » | no next file with comments »