Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 160272: X64: Added inline keyed load/store and a bunch of other missing functions. (Closed)
Patch Set: Addressed review comments, and fixed bugs introduced by updating. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1117 void Assembler::movq(const Operand& dst, Register src) { 1117 void Assembler::movq(const Operand& dst, Register src) {
1118 EnsureSpace ensure_space(this); 1118 EnsureSpace ensure_space(this);
1119 last_pc_ = pc_; 1119 last_pc_ = pc_;
1120 emit_rex_64(src, dst); 1120 emit_rex_64(src, dst);
1121 emit(0x89); 1121 emit(0x89);
1122 emit_operand(src, dst); 1122 emit_operand(src, dst);
1123 } 1123 }
1124 1124
1125 1125
1126 void Assembler::movq(Register dst, void* value, RelocInfo::Mode rmode) { 1126 void Assembler::movq(Register dst, void* value, RelocInfo::Mode rmode) {
1127 // This method must not be used with heap object references. The stored
1128 // address is not GC safe. Use the handle version instead.
1129 ASSERT(rmode > RelocInfo::LAST_GCED_ENUM);
1127 EnsureSpace ensure_space(this); 1130 EnsureSpace ensure_space(this);
1128 last_pc_ = pc_; 1131 last_pc_ = pc_;
1129 emit_rex_64(dst); 1132 emit_rex_64(dst);
1130 emit(0xB8 | dst.low_bits()); 1133 emit(0xB8 | dst.low_bits());
1131 emitq(reinterpret_cast<uintptr_t>(value), rmode); 1134 emitq(reinterpret_cast<uintptr_t>(value), rmode);
1132 } 1135 }
1133 1136
1134 1137
1135 void Assembler::movq(Register dst, int64_t value, RelocInfo::Mode rmode) { 1138 void Assembler::movq(Register dst, int64_t value, RelocInfo::Mode rmode) {
1136 // Non-relocatable values might not need a 64-bit representation. 1139 // Non-relocatable values might not need a 64-bit representation.
(...skipping 1048 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 RecordRelocInfo(RelocInfo::POSITION, current_position_); 2188 RecordRelocInfo(RelocInfo::POSITION, current_position_);
2186 written_position_ = current_position_; 2189 written_position_ = current_position_;
2187 } 2190 }
2188 } 2191 }
2189 2192
2190 2193
2191 const int RelocInfo::kApplyMask = 1 << RelocInfo::INTERNAL_REFERENCE; 2194 const int RelocInfo::kApplyMask = 1 << RelocInfo::INTERNAL_REFERENCE;
2192 2195
2193 2196
2194 } } // namespace v8::internal 2197 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698