Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1602016: Add tpmd_dev from the tpm-emulator source to the kernel (Closed)

Created:
10 years, 8 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, mbligh, Mandeep Singh Baines, sleffler+cc_chromium.org
Visibility:
Public.

Description

Add tpmd_dev from the tpm-emulator source to the kernel This adds tpmd_dev from the tpm-emulator source, so we don't have to compile it externally. It also adds config.h, which unfortunately is not in the source---it's an intermediate compilation result. Signed-off-by: semenzato@chromium.org

Patch Set 1 #

Patch Set 2 : revert kconfig change #

Patch Set 3 : fixes from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -0 lines) Patch
M chromeos/drivers/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A chromeos/drivers/tpmd_dev/Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
A chromeos/drivers/tpmd_dev/config.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chromeos/drivers/tpmd_dev/tpmd_dev.c View 1 chunk +271 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mandeep Singh Baines
Codes looks good but could you please update the commit message include a one line ...
10 years, 8 months ago (2010-04-09 22:38:47 UTC) #1
Luigi Semenzato
On 2010/04/09 22:38:47, msb wrote: > Codes looks good but could you please update the ...
10 years, 8 months ago (2010-04-09 22:44:37 UTC) #2
Luigi Semenzato
On 2010/04/09 22:44:37, Luigi Semenzato wrote: > On 2010/04/09 22:38:47, msb wrote: > > Codes ...
10 years, 8 months ago (2010-04-09 22:58:30 UTC) #3
Luigi Semenzato
PTAL!
10 years, 8 months ago (2010-04-09 23:02:12 UTC) #4
Mandeep Singh Baines
git-cl will use the description displayed by codereview.chromium.org so you'll need to edit the description ...
10 years, 8 months ago (2010-04-09 23:19:15 UTC) #5
Luigi Semenzato
On 2010/04/09 23:19:15, msb wrote: > git-cl will use the description displayed by http://codereview.chromium.org so ...
10 years, 8 months ago (2010-04-09 23:27:22 UTC) #6
Mandeep Singh Baines
10 years, 8 months ago (2010-04-09 23:49:59 UTC) #7
LGTM. Thanks much!

Powered by Google App Engine
This is Rietveld 408576698