Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1602010: Add number string cache lookup for heap numbers to generatred code (on top of... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add number string cache lookup for heap numbers to generatred code (on top of the already existing smi lookup) Added a number to string runtime function which does not try to do a cache lookup as the number is known to not be in the cahce. Committed: http://code.google.com/p/v8/source/detail?r=4355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -20 lines) Patch
M src/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +57 lines, -14 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-06 19:43:12 UTC) #1
Mads Ager (chromium)
10 years, 8 months ago (2010-04-07 10:47:52 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698