Issue 160174: X64: Add parentheses to buggy expression in disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160174: X64: Add parentheses to buggy expression in disassembler. (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Fix buggy expression in disassembler. Fixes Issue 408: http://code.google.com/p/v8/issues/detail?id=408 Committed: http://code.google.com/p/v8/source/detail?r=2544

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/x64/disasm-x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Simple parenthesis error. Anybody want to approve it?

11 years, 5 months ago (2009-07-27 18:26:39 UTC) #1

iposva

LGTM. Another lesson that you just can't trust the C-precedence rules to be "correct". Which ...

11 years, 5 months ago (2009-07-27 18:34:00 UTC) #2

William Hesse

11 years, 5 months ago (2009-07-27 18:51:11 UTC) #3

But the whole expression was too complicated.  Should have been *data == 0xA3.
Changed.


On 2009/07/27 18:34:00, iposva wrote:
> LGTM.
> 
> Another lesson that you just can't trust the C-precedence rules to be
"correct".
> Which is why I always put parens in expressions even if they seem redundant.
> 
> -Ivan

Expand Messages | Collapse Messages