Issue 160169: Merge 21266 - This CL fixes issue 5996: Tooltip gets direction from Chrome la...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160169: Merge 21266 - This CL fixes issue 5996: Tooltip gets direction from Chrome la... (Closed)

Created:
11 years, 5 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
xji

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21266 - This CL fixes issue 5996: Tooltip gets direction from Chrome langauge, not element (or even page) The related webkit bug is https://bugs.webkit.org/show_bug.cgi?id=24187 After webkit passes both the title string and its directionality to its client, Chrome will force the title to be displayed in correct directionality using Unicode Control characters. BUG=http://crbug.com/5996 TEST=In both English Chrome and Hebrew Chrome 1. open the test case in http://crbug.com/5996 comment #1 2. hover over the red span, tooltip should be displayed as RTL in both English Chrome and Hebrew Chrome. 3. hover over the blue span, tooltip should be displayed as LTR in both English Chrome and Hebrew Chrome. Review URL: http://codereview.chromium.org/147240 TBR=xji@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21654

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	MM	webkit/glue/chrome_client_impl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	MM	webkit/glue/chrome_client_impl.cc	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xji

11 years, 5 months ago (2009-07-27 18:31:59 UTC) #2

You need to merge 21353 as well.
The above CL causes regression: empty rectangle always show up in webpage.

On 2009/07/27 17:20:56, laforge wrote:
>

Expand Messages | Collapse Messages