Issue 160116: Implement feature where tabs don't resize when using the close box until the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160116: Implement feature where tabs don't resize when using the close box until the ... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Implement feature where tabs don't resize when using the close box until the mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things. BUG=14912 TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21581

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -8 lines)			Patch
	M	chrome/browser/cocoa/tab_strip_controller.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/tab_strip_controller.mm	View	1 2	10 chunks	+81 lines, -8 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 5 months ago (2009-07-24 20:35:56 UTC) #2

LGTM

http://codereview.chromium.org/160116/diff/9/11
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/160116/diff/9/11#newcode189
Line 189: NSView* penultimateTab = [self viewAtIndex:[tabArray_ count] - 2];
Will we have to revisit this once we implement reasonable tab overflow behavior?
 If so, add a TODO?

Expand Messages | Collapse Messages