Issue 160099: A small cleanup of MacOSMutex constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160099: A small cleanup of MacOSMutex constructor (Closed)

Created:
11 years, 5 months ago by the_wrong_timurrrr

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev, Dean McNamee

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	src/platform-macos.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

the_wrong_timurrrr

Hi Ivan, I'd like you to do a small code review. The original MacOSMutex constructor ...

11 years, 5 months ago (2009-07-24 14:02:52 UTC) #1

iposva

LGTM -ip P.S. Since you do not have submit rights to the V8 code, I ...

11 years, 5 months ago (2009-07-24 18:06:57 UTC) #2

the_wrong_timurrrr

On 2009/07/24 18:06:57, iposva wrote: > LGTM -ip > > P.S. Since you do not ...

11 years, 5 months ago (2009-07-24 18:20:47 UTC) #3

iposva

11 years, 5 months ago (2009-07-27 05:36:43 UTC) #4

Landed as http://code.google.com/p/v8/source/detail?r=2535

-Ivan

On 2009/07/24 18:20:47, timurrrr wrote:
> On 2009/07/24 18:06:57, iposva wrote:
> > LGTM -ip
> > 
> > P.S. Since you do not have submit rights to the V8 code, I will apply your
> patch
> > for you.
> Thank you very much!

Expand Messages | Collapse Messages