Issue 160098: DevTools: Switch from Value to JSON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160098: DevTools: Switch from Value to JSON. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Sanitize objects being serialized so that prototype.js did not affect JSON.stringify. BUG=19850

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	webkit/glue/devtools/js/inject_dispatch.js	View		2 chunks	+21 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

11 years, 4 months ago (2009-08-26 11:51:42 UTC) #2

LGTM

http://codereview.chromium.org/160098/diff/2001/3001
File webkit/glue/devtools/js/inject_dispatch.js (right):

http://codereview.chromium.org/160098/diff/2001/3001#newcode43
Line 43: obj[name] = null;
is it safe to do in the 'for in' loop?

http://codereview.chromium.org/160098/diff/2001/3001#newcode45
Line 45: sanitizeJson(property);
this will fail if property is null because typeof null ==
'object'

Expand Messages | Collapse Messages