DevTools: make pause work for script evaluations

webkit/glue/devtools/js/inject.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Javascript that is being injected into the inspectable page
  * while debugging.
  */
 goog.provide('devtools.Injected');
 
@@ skipping 527 matching lines @@
 };
 
 
 /**
  * Caches console object for subsequent calls to getConsoleObjectProperties.
  * @param {Object} obj Object to cache.
  * @return {Object} console object wrapper.
  */
 devtools.Injected.prototype.wrapConsoleObject = function(obj) {
   var type = typeof obj;
-  if (type == 'object' || type == 'function') {
+  if ((type == 'object' && obj != null) || type == 'function') {
     var objId = '#consoleobj#' + this.lastCachedConsoleObjectId_++;
     this.cachedConsoleObjects_[objId] = obj;
     var result = { ___devtools_id : objId };
     // Loop below fills dummy object with properties for completion.
     for (var name in obj) {
       result[name] = '';
     }
     return result;
-  } else {
-    return obj;
   }
+  return obj;
 };
 
 
 /**
  * Caches console object for subsequent calls to getConsoleObjectProperties.
  * @param {Object} obj Object to cache.
- * @return {string} console object id.
+ * @return {string} Console object wrapper serialized into a JSON string.
  */
-devtools.Injected.prototype.evaluate = function(expression) {
-  try {
-    // Evaluate the expression in the global context of the inspected window.
-    return [ this.wrapConsoleObject(contentWindow.eval(expression)), false ];
-  } catch (e) {
-    return [ e.toString(), true ];
-  }
+devtools.Injected.prototype.serializeConsoleObject = function(obj) {
+  var result = this.wrapConsoleObject(obj);
+  return JSON.stringify(result,
+      function (key, value) {
+        if (value === undefined) {
+         return 'undefined';
+        }
+        return value;
+      });
 };
 
 
 /**
  * Dispatches given method with given args on the host object.
  * @param {string} method Method name.
  */
 devtools.Injected.prototype.InspectorController = function(method, var_args) {
   var args = Array.prototype.slice.call(arguments, 1);
   return InspectorController[method].apply(InspectorController, args);
 };