Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 160009: Fix typo in last change (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 // Is it a string? 284 // Is it a string?
285 __ CmpObjectType(eax, FIRST_NONSTRING_TYPE, edx); 285 __ CmpObjectType(eax, FIRST_NONSTRING_TYPE, edx);
286 __ j(above_equal, &slow); 286 __ j(above_equal, &slow);
287 // Is the string an array index, with cached numeric value? 287 // Is the string an array index, with cached numeric value?
288 __ mov(ebx, FieldOperand(eax, String::kLengthOffset)); 288 __ mov(ebx, FieldOperand(eax, String::kLengthOffset));
289 __ test(ebx, Immediate(String::kIsArrayIndexMask)); 289 __ test(ebx, Immediate(String::kIsArrayIndexMask));
290 __ j(not_zero, &index_string, not_taken); 290 __ j(not_zero, &index_string, not_taken);
291 291
292 // If the string is a symbol, do a quick inline probe of the receiver's 292 // If the string is a symbol, do a quick inline probe of the receiver's
293 // dictionary, if it exists. 293 // dictionary, if it exists.
294 __ movzx_b(ebx, FieldOperand(exd, Map::kInstanceTypeOffset)); 294 __ movzx_b(ebx, FieldOperand(edx, Map::kInstanceTypeOffset));
295 __ test(ebx, Immediate(kIsSymbolMask)); 295 __ test(ebx, Immediate(kIsSymbolMask));
296 __ j(zero, &slow, not_taken); 296 __ j(zero, &slow, not_taken);
297 // Probe the dictionary leaving result in ecx. 297 // Probe the dictionary leaving result in ecx.
298 GenerateDictionaryLoad(masm, &slow, ebx, ecx, edx, eax); 298 GenerateDictionaryLoad(masm, &slow, ebx, ecx, edx, eax);
299 GenerateCheckNonObjectOrLoaded(masm, &slow, ecx, edx); 299 GenerateCheckNonObjectOrLoaded(masm, &slow, ecx, edx);
300 __ mov(eax, Operand(ecx)); 300 __ mov(eax, Operand(ecx));
301 __ IncrementCounter(&Counters::keyed_load_generic_symbol, 1); 301 __ IncrementCounter(&Counters::keyed_load_generic_symbol, 1);
302 __ ret(0); 302 __ ret(0);
303 // Array index string: If short enough use cache in length/hash field (ebx). 303 // Array index string: If short enough use cache in length/hash field (ebx).
304 // We assert that there are enough bits in an int32_t after the hash shift 304 // We assert that there are enough bits in an int32_t after the hash shift
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 990
991 // Do tail-call to runtime routine. 991 // Do tail-call to runtime routine.
992 __ TailCallRuntime( 992 __ TailCallRuntime(
993 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3); 993 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3);
994 } 994 }
995 995
996 #undef __ 996 #undef __
997 997
998 998
999 } } // namespace v8::internal 999 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698