Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 160006: Fix ARM compiler crash in short-circuited boolean expressions.... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix ARM compiler crash in short-circuited boolean expressions. We did not handle the case where the left-hand-side expression was fully compiled to control flow. There were also some assertions for unary and binary expressions that crashed debug builds when the expression was fully compiled to control flow. Regression test added. Committed: http://code.google.com/p/v8/source/detail?r=2524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -27 lines) Patch
M src/arm/codegen-arm.cc View 6 chunks +41 lines, -27 lines 0 comments Download
A test/mjsunit/regress/regress-406.js View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-23 09:46:17 UTC) #1
Mads Ager (chromium)
11 years, 5 months ago (2009-07-23 11:32:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698