Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2787)

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 159858: Port more tests from save_page_uitest.cc to save_page_browsertest.cc. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/test/data/save_page/b.saved1.htm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.cc
diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc
index 7fcbe0a4f520fee91fb11216a02debdbbb7b25bf..4ca3006862fc30cc31aa6ae008f65f191d76edbc 100644
--- a/chrome/browser/tab_contents/tab_contents.cc
+++ b/chrome/browser/tab_contents/tab_contents.cc
@@ -1029,7 +1029,7 @@ void TabContents::OnSavePage() {
// Used in automated testing to bypass prompting the user for file names.
// Instead, the names and paths are hard coded rather than running them through
// file name sanitation and extension / mime checking.
-void TabContents::SavePage(const std::wstring& main_file,
+bool TabContents::SavePage(const std::wstring& main_file,
const std::wstring& dir_path,
SavePackage::SavePackageType save_type) {
// Stop the page from navigating.
@@ -1038,7 +1038,7 @@ void TabContents::SavePage(const std::wstring& main_file,
save_package_ = new SavePackage(this, save_type,
FilePath::FromWStringHack(main_file),
FilePath::FromWStringHack(dir_path));
- save_package_->Init();
+ return save_package_->Init();
}
void TabContents::PrintPreview() {
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/test/data/save_page/b.saved1.htm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698