Issue 159858: Port more tests from save_page_uitest.cc to save_page_browsertest.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159858: Port more tests from save_page_uitest.cc to save_page_browsertest.cc. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Port more tests from save_page_uitest.cc to save_page_browsertest.cc. Also add more detailed checks for saved page contents. TEST=Covered by browser_tests. http://crbug.com/3791 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22413

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -57 lines)			Patch
M	chrome/browser/download/save_page_browsertest.cc	View	5 chunks	+58 lines, -5 lines	0 comments	Download
M	chrome/browser/download/save_page_uitest.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/test/data/save_page/b.saved1.htm	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/save_page/b.saved2.htm	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

No problems finishing the test. Thanks for your help.

11 years, 4 months ago (2009-08-04 16:23:53 UTC) #1

LGTM