[Mac] Select the previous node when the last cookie in the list is deleted.

[Mac] Select the previous node when the last cookie in the list is deleted.

Also recursively bubble up the delete if removing a child node will leave the
parent empty. Empty parents look awkward.

BUG=33320
TEST=See bug report. Partially covered by unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43157

[John Grabowski, 2010-03-30 22:20:04]

http://codereview.chromium.org/1598001/diff/1/3
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/1598001/diff/1/3#newcode277
chrome/browser/cocoa/cookies_window_controller.mm:277: DCHECK_EQ(1U,
[[treeController_ selectedObjects] count]);
I should be allowed to shift-select multiple cookies and delete them all, yes? 
Or do you disable Delete when >1 is selected with KVO magic?

http://codereview.chromium.org/1598001/diff/1/3#newcode283
chrome/browser/cocoa/cookies_window_controller.mm:283: // was the sole sibling
of the parent node, this will be called recursively to
"was the sole CHILD of the parent node"

http://codereview.chromium.org/1598001/diff/1/3#newcode299
chrome/browser/cocoa/cookies_window_controller.mm:299: if ([[treeController_
selectedObjects] count] < 1) {
if (! ... )
<1 implies there are multiple options.

http://codereview.chromium.org/1598001/diff/1/4
File chrome/browser/cocoa/cookies_window_controller_unittest.mm (right):

http://codereview.chromium.org/1598001/diff/1/4#newcode377
chrome/browser/cocoa/cookies_window_controller_unittest.mm:377: NSUInteger
pathA[3] = {0, 0, 0};
Document which cookie this is

http://codereview.chromium.org/1598001/diff/1/4#newcode402
chrome/browser/cocoa/cookies_window_controller_unittest.mm:402: 
Do we need to test "delete last cookie of them all" which, following the tree,
will not end up with a valid path to select once we're done deleting?

[Robert Sesek, 2010-03-30 22:36:53]

http://codereview.chromium.org/1598001/diff/1/3
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/1598001/diff/1/3#newcode277
chrome/browser/cocoa/cookies_window_controller.mm:277: DCHECK_EQ(1U,
[[treeController_ selectedObjects] count]);
On 2010/03/30 22:20:05, John Grabowski wrote:
> I should be allowed to shift-select multiple cookies and delete them all, yes?

> Or do you disable Delete when >1 is selected with KVO magic?

We twiddle a |removeButtonEnabled_| flag to only allow single selection.

http://codereview.chromium.org/1598001/diff/1/3#newcode283
chrome/browser/cocoa/cookies_window_controller.mm:283: // was the sole sibling
of the parent node, this will be called recursively to
On 2010/03/30 22:20:05, John Grabowski wrote:
> "was the sole CHILD of the parent node"
> 

Done.

http://codereview.chromium.org/1598001/diff/1/3#newcode299
chrome/browser/cocoa/cookies_window_controller.mm:299: if ([[treeController_
selectedObjects] count] < 1) {
On 2010/03/30 22:20:05, John Grabowski wrote:
> if (! ... )
> <1 implies there are multiple options.
> 

That's what I had originally and then I changed it this. Heh. Done.

http://codereview.chromium.org/1598001/diff/1/4
File chrome/browser/cocoa/cookies_window_controller_unittest.mm (right):

http://codereview.chromium.org/1598001/diff/1/4#newcode377
chrome/browser/cocoa/cookies_window_controller_unittest.mm:377: NSUInteger
pathA[3] = {0, 0, 0};
On 2010/03/30 22:20:05, John Grabowski wrote:
> Document which cookie this is

I believe it already is documented?

http://codereview.chromium.org/1598001/diff/1/4#newcode402
chrome/browser/cocoa/cookies_window_controller_unittest.mm:402: 
On 2010/03/30 22:20:05, John Grabowski wrote:
> Do we need to test "delete last cookie of them all" which, following the tree,
> will not end up with a valid path to select once we're done deleting?

Sounds reasonable and not that hard to do. Done.

[John Grabowski, 2010-03-30 22:57:16]

LGTM

http://codereview.chromium.org/1598001/diff/1/4
File chrome/browser/cocoa/cookies_window_controller_unittest.mm (right):

http://codereview.chromium.org/1598001/diff/1/4#newcode377
chrome/browser/cocoa/cookies_window_controller_unittest.mm:377: NSUInteger
pathA[3] = {0, 0, 0};
On 2010/03/30 22:36:53, rsesek wrote:
> On 2010/03/30 22:20:05, John Grabowski wrote:
> > Document which cookie this is
> 
> I believe it already is documented?

Ah... yes.  "A" is "cookie A", and not "variable A in the list of varA, varB,
varC, ..."