Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: base/logging.cc

Issue 159789: Remove even the logging statement from ~LogMessage. We shouldn't be using LOG macros there. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 27f2724f0f59999a3112b07e7fb362778f9a9b2e..19243482993ece1e025d8435dbc222a358e2f00c 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -485,12 +485,11 @@ LogMessage::~LogMessage() {
#if defined(OS_WIN)
DWORD r = ::WaitForSingleObject(log_mutex, INFINITE);
- if (r == WAIT_ABANDONED) {
- // Do not abort the process here. UI tests might be crashy sometimes,
- // and aborting the test binary only makes the problem worse.
- // For more info see http://crbug.com/18028.
- LOG(ERROR) << "Thread owning the log mutex has crashed.";
- }
+ // WaitForSingleObject could have returned WAIT_ABANDONED. We don't
+ // abort the process here. UI tests might be crashy sometimes,
+ // and aborting the test binary only makes the problem worse.
+ // We also don't use LOG macros because that might lead to an infinite
+ // loop. For more info see http://crbug.com/18028.
#elif defined(OS_POSIX)
pthread_mutex_lock(&log_mutex);
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698