Issue 159784: Removed unsafe optimization in RecordWrite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159784: Removed unsafe optimization in RecordWrite. (Closed)

Created:
11 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Removed unsafe optimization in RecordWrite. Optimization was only unsafe if new-space was in the low half of memory and an object could be located in the top half at an addressed that only differ from a new-space address by the high bit.

Patch Set 1 #

Created: 11 years, 4 months ago

		Unified diffs	Side-by-side diffs	Stats (+21 lines, -30 lines)
	M	src/ia32/assembler-ia32.h	View	1 chunk	+3 lines, -1 line	0 comments
	M	src/ia32/macro-assembler-ia32.cc	View	3 chunks	+18 lines, -29 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages