Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4234)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 159777: Add about:memory support for Linux.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler.cc
===================================================================
--- chrome/browser/browser_about_handler.cc (revision 22256)
+++ chrome/browser/browser_about_handler.cc (working copy)
@@ -510,17 +510,17 @@
ListValue* browsers = new ListValue();
root.Set(L"browsers", browsers);
- ProcessData* browser_processes = processes();
+ const std::vector<ProcessData>& browser_processes = processes();
// Aggregate per-process data into browser summary data.
std::wstring log_string;
- for (int index = 0; index < MemoryDetails::MAX_BROWSERS; index++) {
+ for (unsigned int index = 0; index < browser_processes.size(); index++) {
Evan Martin 2009/08/03 05:16:11 size_t
if (browser_processes[index].processes.size() == 0)
continue;
// Sum the information for the processes within this browser.
ProcessMemoryInformation aggregate;
- ProcessMemoryInformationList::iterator iterator;
+ ProcessMemoryInformationList::const_iterator iterator;
iterator = browser_processes[index].processes.begin();
aggregate.pid = iterator->pid;
aggregate.version = iterator->version;

Powered by Google App Engine
This is Rietveld 408576698