Add renderer histograms for late binding of sockets.

Add renderer histograms for late binding of sockets.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22250

[jar (doing other things), 2009-08-01 05:30:23]

http://codereview.chromium.org/159759/diff/1/2
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/159759/diff/1/2#newcode3015
Line 3015: static bool
use_sdch_histogram(FieldTrialList::Find("SocketLateBinding") &&
You need to change the name of this boolean to something other than the name
which was already used above.  I'm surprised this compiled.

http://codereview.chromium.org/159759/diff/1/2#newcode3017
Line 3017: if (use_sdch_histogram) {
...and of course its use here has to be renamed.

[willchan no longer on Chromium, 2009-08-01 07:56:05]

Er, it didn't compile :P  That's what I get for rushing to finish a changelist
before dinner.  It compiles now :)

On 2009/08/01 05:30:23, jar wrote:
> http://codereview.chromium.org/159759/diff/1/2
> File chrome/renderer/render_view.cc (right):
> 
> http://codereview.chromium.org/159759/diff/1/2#newcode3015
> Line 3015: static bool
> use_sdch_histogram(FieldTrialList::Find("SocketLateBinding") &&
> You need to change the name of this boolean to something other than the name
> which was already used above.  I'm surprised this compiled.
> 
> http://codereview.chromium.org/159759/diff/1/2#newcode3017
> Line 3017: if (use_sdch_histogram) {
> ...and of course its use here has to be renamed.

[jar (doing other things), 2009-08-01 16:57:00]

LGTM

Thanks!