Issue 159754: GTK Themes: Fix painting issues where GTK theme engine was painting over buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159754: GTK Themes: Fix painting issues where GTK theme engine was painting over buttons. (Closed)

Created:
11 years, 4 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, James Hawkins, Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK Themes: Fix painting issues where GTK theme engine was painting over buttons. So it looks like some themeing engines in distros more recent than Hardy paint random boxes of the default background if you don't pass an explicit clip area to gtk_paint_shadow(). http://crbug.com/18129 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22242

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		2 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG

Expand Messages | Collapse Messages