Issue 159753: Linux: Fix Valgrind error in VisitedLinkEventsTest.Coalescense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159753: Linux: Fix Valgrind error in VisitedLinkEventsTest.Coalescense. (Closed)

Created:
11 years, 4 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: Fix Valgrind error in VisitedLinkEventsTest.Coalescense. I introduced the error in r22193; it shows up when there's no X server to connect to. I get a "GLib-GObject-CRITICAL **: g_object_get: assertion `G_IS_OBJECT (object)' failed" message with this change, but I'm not sure if it's from my code or if it was already there, and the tests still pass. TEST=ran VisitedLinkEventsTest.Coalescense under Valgrind with DISPLAY=:6 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22240

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -1 line)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/common/x11_util.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/x11_util.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages