Issue 159748: GTK: Theme our link button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159748: GTK: Theme our link button. (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Theme our link button. BUG=17772 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22226

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comment #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -29 lines)			Patch
M	chrome/browser/gtk/bookmark_bubble_gtk.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bubble_gtk.cc	View	1	4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/download_shelf_gtk.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.cc	View		4 chunks	+80 lines, -26 lines	0 comments	Download
M	chrome/browser/gtk/infobar_gtk.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 4 months ago (2009-07-31 23:26:02 UTC) #2

LGTM with nit

http://codereview.chromium.org/159748/diff/1/7
File chrome/browser/gtk/bookmark_bubble_gtk.cc (right):

http://codereview.chromium.org/159748/diff/1/7#newcode162
Line 162: GTK_CHROME_LINK_BUTTON(remove_button_), FALSE);
You shouldn't have to do this, as theme_provider_->InitThemesFor(this); is
called below and that should simulate a BROWSER_THEME_CHANGED notification to
this object.

Expand Messages | Collapse Messages