Issue 159745: Fix a bug where we tried to get the position of the tabstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159745: Fix a bug where we tried to get the position of the tabstrip (Closed)

Created:
11 years, 4 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a bug where we tried to get the position of the tabstrip but the tabstrip wasn't in our widget hierarchy for app mode windows. Now we always put the tabstrip in the hierarchy, even if we don't show it. BUG=18202

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	chrome/browser/gtk/browser_titlebar.cc	View		2 chunks	+14 lines, -7 lines	0 comments	Download
	M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 4 months ago (2009-07-31 22:57:48 UTC) #2

lgtm (hopefully there's no show_all call that will make it appear)

Expand Messages | Collapse Messages