Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: webkit/glue/plugins/webplugin_delegate_impl.h

Issue 159717: Don't call NPP_SetWindow during the painting of windowless plugins.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Fix for url_request_mock_http_job move. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/plugin/plugin_test.cpp ('k') | webkit/glue/plugins/webplugin_delegate_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_ 5 #ifndef WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_
6 #define WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_ 6 #define WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #include <string> 10 #include <string>
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 // Closes down and destroys our plugin instance. 155 // Closes down and destroys our plugin instance.
156 void DestroyInstance(); 156 void DestroyInstance();
157 157
158 #if !defined(OS_MACOSX) 158 #if !defined(OS_MACOSX)
159 // used for windowed plugins 159 // used for windowed plugins
160 gfx::PluginWindowHandle windowed_handle_; 160 gfx::PluginWindowHandle windowed_handle_;
161 bool windowed_did_set_window_; 161 bool windowed_did_set_window_;
162 gfx::Rect windowed_last_pos_; 162 gfx::Rect windowed_last_pos_;
163 #endif 163 #endif
164 164
165 // TODO(dglazkov): No longer used by Windows, make sure the removal
166 // causes no regressions and eliminate from other platforms.
165 // this is an optimization to avoid calling SetWindow to the plugin 167 // this is an optimization to avoid calling SetWindow to the plugin
166 // when it is not necessary. Initially, we need to call SetWindow, 168 // when it is not necessary. Initially, we need to call SetWindow,
167 // and after that we only need to call it when the geometry changes. 169 // and after that we only need to call it when the geometry changes.
168 // use this flag to indicate whether we really need it or not. 170 // use this flag to indicate whether we really need it or not.
169 bool windowless_needs_set_window_; 171 bool windowless_needs_set_window_;
170 172
171 // used by windowed and windowless plugins 173 // used by windowed and windowless plugins
172 bool windowless_; 174 bool windowless_;
173 175
174 WebPlugin* plugin_; 176 WebPlugin* plugin_;
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 288
287 // Holds the current cursor set by the windowless plugin. 289 // Holds the current cursor set by the windowless plugin.
288 WebCursor current_windowless_cursor_; 290 WebCursor current_windowless_cursor_;
289 291
290 friend class WebPluginDelegate; 292 friend class WebPluginDelegate;
291 293
292 DISALLOW_EVIL_CONSTRUCTORS(WebPluginDelegateImpl); 294 DISALLOW_EVIL_CONSTRUCTORS(WebPluginDelegateImpl);
293 }; 295 };
294 296
295 #endif // #ifndef WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_ 297 #endif // #ifndef WEBKIT_GLUE_PLUGIN_WEBPLUGIN_DELEGATE_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/test/plugin/plugin_test.cpp ('k') | webkit/glue/plugins/webplugin_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698