Implement kCurrentThemeID so we can know what the last theme to be installed ...

Implement kCurrentThemeID so we can know what the last theme to be installed was.

BUG=none
TEST=not visible in UI


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22270

[Erik does not do reviews, 2009-08-01 03:46:52]

http://codereview.chromium.org/159705/diff/1/5
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/159705/diff/1/5#newcode785
Line 785: SaveThemeID("");
so "" is the default theme id?  Maybe make that a constant so that it can be
more clearly compared against later?  Also change where the register happens to
use this same value.

http://codereview.chromium.org/159705/diff/1/3
File chrome/browser/browser_theme_provider.h (right):

http://codereview.chromium.org/159705/diff/1/3#newcode278
Line 278: // Save the id of the last theme installed
nit: newline above comment, period at end of sentence

http://codereview.chromium.org/159705/diff/1/4
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/159705/diff/1/4#newcode989
Line 989: std::string id = theme_provider_.get()->GetThemeID();
Since the default theme id is "", why not explicitly check for that here and
return NULL.

[Avi (use Gerrit), 2009-08-03 15:00:09]

All addressed.

http://codereview.chromium.org/159705/diff/1/5
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/159705/diff/1/5#newcode785
Line 785: SaveThemeID("");
On 2009/08/01 03:46:52, Erik Kay wrote:
> so "" is the default theme id?  Maybe make that a constant so that it can be
> more clearly compared against later?  Also change where the register happens
to
> use this same value.

Done.

http://codereview.chromium.org/159705/diff/1/4
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/159705/diff/1/4#newcode989
Line 989: std::string id = theme_provider_.get()->GetThemeID();
On 2009/08/01 03:46:52, Erik Kay wrote:
> Since the default theme id is "", why not explicitly check for that here and
> return NULL.

Done.

[Erik does not do reviews, 2009-08-03 15:44:26]

LGTM