Allow stepping in functions called using CallFunction stub

Allow stepping in functions called using CallFunction stub. When Debug::PrepareStep is called to prepare 'step in' and current code target is CallFunction stub, the debugger will find function being called on the expression stack and flood it with one shot breakpoints.Related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=17978

Committed: http://code.google.com/p/v8/source/detail?r=2745

[Søren Thygesen Gjesse, 2009-08-03 07:36:19]

LGTM

http://codereview.chromium.org/159703/diff/1/4
File src/debug.cc (right):

http://codereview.chromium.org/159703/diff/1/4#newcode321
Line 321: // construct call.
Please update this comment to reflect the CallFunction stub as well.

http://codereview.chromium.org/159703/diff/1/4#newcode324
Line 324: if (code->is_call_stub()) {
Please add a Handle here to avoid unexpected GC issues when changing the code (I
know it is not your code).

http://codereview.chromium.org/159703/diff/1/4#newcode339
Line 339: if (IsDebugBreak()) {
And here.

http://codereview.chromium.org/159703/diff/1/4#newcode1169
Line 1169: Object* obj =
Heap::code_stubs()->SlowReverseLookup(*call_function_stub);
Please use a Handle here even though not strictly required.

http://codereview.chromium.org/159703/diff/1/4#newcode1190
Line 1190: JSFunction* js_function = JSFunction::cast(fun);
And here.

[yurys, 2009-08-24 15:15:05]

http://codereview.chromium.org/159703/diff/1/4
File src/debug.cc (right):

http://codereview.chromium.org/159703/diff/1/4#newcode321
Line 321: // construct call.
On 2009/08/03 07:36:19, Søren Gjesse wrote:
> Please update this comment to reflect the CallFunction stub as well.

Done.

http://codereview.chromium.org/159703/diff/1/4#newcode324
Line 324: if (code->is_call_stub()) {
On 2009/08/03 07:36:19, Søren Gjesse wrote:
> Please add a Handle here to avoid unexpected GC issues when changing the code
(I
> know it is not your code).

Done.

http://codereview.chromium.org/159703/diff/1/4#newcode339
Line 339: if (IsDebugBreak()) {
On 2009/08/03 07:36:19, Søren Gjesse wrote:
> And here.

Done.

http://codereview.chromium.org/159703/diff/1/4#newcode1169
Line 1169: Object* obj =
Heap::code_stubs()->SlowReverseLookup(*call_function_stub);
On 2009/08/03 07:36:19, Søren Gjesse wrote:
> Please use a Handle here even though not strictly required.

Done.

http://codereview.chromium.org/159703/diff/1/4#newcode1190
Line 1190: JSFunction* js_function = JSFunction::cast(fun);
On 2009/08/03 07:36:19, Søren Gjesse wrote:
> And here.

Done.