Issue 159701: Restructure to support recursive invocation of the CFG builder. Add...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159701: Restructure to support recursive invocation of the CFG builder. Add... (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Restructure to support recursive invocation of the CFG builder. Add support for stack-allocated variables when run with multipass. There is no liveness analysis and they are currently always allocated to memory.

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -68 lines)			Patch
M	src/arm/cfg-arm.cc	View	3 chunks	+23 lines, -3 lines	0 comments	Download
M	src/cfg.h	View	13 chunks	+82 lines, -24 lines	0 comments	Download
M	src/cfg.cc	View	8 chunks	+53 lines, -33 lines	2 comments	Download
M	src/compiler.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/ia32/cfg-ia32.cc	View	3 chunks	+24 lines, -3 lines	0 comments	Download
M	src/x64/cfg-x64.cc	View	3 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/159701/diff/1/5 File src/cfg.cc (right): http://codereview.chromium.org/159701/diff/1/5#newcode123 Line 123: void ExitNode::Unmark() { is_marked_ = false; } ...

11 years, 4 months ago (2009-08-03 05:55:44 UTC) #2

Kevin Millikin (Chromium)

11 years, 4 months ago (2009-08-03 07:54:43 UTC) #3

http://codereview.chromium.org/159701/diff/1/5
File src/cfg.cc (right):

http://codereview.chromium.org/159701/diff/1/5#newcode123
Line 123: void ExitNode::Unmark() { is_marked_ = false; }
On 2009/08/03 05:55:44, Kasper Lund wrote:
> I would put this on three lines.

Done.

Expand Messages | Collapse Messages