Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 159659: - Fix a style violation which was flagged by gcc: while loop without body... (Closed)

Created:
11 years, 4 months ago by iposva
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Fix a style violation which was flagged by gcc: while loop without body - Restructured the entire function because: During the simple style fix I discovered that this whole routine was hard to read due to a general lack of comments. While adding comments I realized that the function was also skipping entries if there were two consecutive entries in the maps file.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M src/platform-linux.cc View 1 chunk +38 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
iposva
11 years, 4 months ago (2009-07-30 21:09:27 UTC) #1
mnaganov (inactive)
LGTM! Great, now it looks perfect. Thanks for spending your time on it!
11 years, 4 months ago (2009-07-31 07:23:15 UTC) #2
iposva
11 years, 4 months ago (2009-08-01 06:13:34 UTC) #3
Committed as r2603.

Powered by Google App Engine
This is Rietveld 408576698