Issue 159643: Disk cache: Remove remaining uses of RankingsNode.pointer....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159643: Disk cache: Remove remaining uses of RankingsNode.pointer.... (Closed)

Created:
11 years, 4 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Remove remaining uses of RankingsNode.pointer. We now have a map of open entries so we don't need to do a lookup through the rankings node anymore. This simplifies the 64 bit version of the code. BUG=17881 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22074

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -47 lines)			Patch
M	net/disk_cache/backend_impl.h	View	1 chunk	+4 lines, -3 lines	1 comment	Download
M	net/disk_cache/backend_impl.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View	2 chunks	+45 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_format.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.cc	View	7 chunks	+4 lines, -17 lines	0 comments	Download
M	net/disk_cache/eviction.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/disk_cache/rankings.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	net/disk_cache/rankings.cc	View	9 chunks	+33 lines, -16 lines	0 comments	Download
M	net/disk_cache/storage_block.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	net/disk_cache/storage_block-inl.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	net/tools/dump_cache/dump_files.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 4 months ago (2009-07-30 18:37:28 UTC) #2

LGTM with one nit! see below

http://codereview.chromium.org/159643/diff/1/4
File net/disk_cache/backend_impl.h (right):

http://codereview.chromium.org/159643/diff/1/4#newcode109
Line 109: // returns a pointer to that entry, oterwise returns NULL. Note that
this
otherwise

Expand Messages | Collapse Messages