Issue 159641: Add Linux package building target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159641: Add Linux package building target. (Closed)

Created:
11 years, 4 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
jon, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add Linux package building target. Also rearrange installer targets with better grouping for easier reading.

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -121 lines)			Patch
	M	build/all.gyp	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	chrome/installer/installer.gyp	View		3 chunks	+165 lines, -121 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Though I admit I don't fully understand it, LGTM http://codereview.chromium.org/159641/diff/1/3 File chrome/installer/installer.gyp (right): http://codereview.chromium.org/159641/diff/1/3#newcode497 Line ...

11 years, 4 months ago (2009-07-30 17:06:52 UTC) #2

Michael Moss

11 years, 4 months ago (2009-07-30 17:15:40 UTC) #3

On 2009/07/30 17:06:52, Evan Martin wrote:
> Though I admit I don't fully understand it, LGTM

Sorry, I should have described the purpose better. This is meant to replace the
current packaging process, which involves manually running a script on the
buildbot output. Now the build will generate the packages directly (for official
builds only), as both Mac and Win do. This should further automate the release
process and save some effort.

> http://codereview.chromium.org/159641/diff/1/3
> File chrome/installer/installer.gyp (right):
> 
> http://codereview.chromium.org/159641/diff/1/3#newcode497
> Line 497: 'process_outputs_as_sources': 1,
> I believe this is flag is only meaningful when you generate .cc/.s files.

Apparently it's needed to actually trigger the actions (I discovered this after
many hours trying to figure out why the packaging script would never run -- sgk
eventually came up with this as the fix).

Expand Messages | Collapse Messages